[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v10 07/16] block: Block all intermediate nodes i
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [PATCH v10 07/16] block: Block all intermediate nodes in commit_active_start() |
Date: |
Wed, 12 Oct 2016 16:06:56 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 06.10.2016 um 15:02 hat Alberto Garcia geschrieben:
> When block-commit is launched without the top parameter, it uses
> internally a mirror block job. In that case all intermediate nodes
> between the active and base nodes must be blocked as well.
>
> Signed-off-by: Alberto Garcia <address@hidden>
Same as the patch before, dataplane is okay because AioContexts are
switched together with the source image.
On second thought, however, maybe both places should set a blocker that
prevents attaching intermediate nodes to a new block device because you
can't read consistent data there. That's a preexisting problem, though,
and needs its own patch.
Reviewed-by: Kevin Wolf <address@hidden>
- [Qemu-block] [PATCH v10 14/16] qemu-iotests: Test block-stream and block-commit in parallel, (continued)
[Qemu-block] [PATCH v10 07/16] block: Block all intermediate nodes in commit_active_start(), Alberto Garcia, 2016/10/06
- Re: [Qemu-block] [PATCH v10 07/16] block: Block all intermediate nodes in commit_active_start(),
Kevin Wolf <=
[Qemu-block] [PATCH v10 15/16] qemu-iotests: Add iotests.supports_quorum(), Alberto Garcia, 2016/10/06
[Qemu-block] [PATCH v10 12/16] qemu-iotests: Test block-stream operations in parallel, Alberto Garcia, 2016/10/06
[Qemu-block] [PATCH v10 11/16] qemu-iotests: Test streaming to an intermediate layer, Alberto Garcia, 2016/10/06