[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v10 07/16] block: Block all intermediate nodes i

From: Kevin Wolf
Subject: Re: [Qemu-block] [PATCH v10 07/16] block: Block all intermediate nodes in commit_active_start()
Date: Wed, 12 Oct 2016 16:06:56 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

Am 06.10.2016 um 15:02 hat Alberto Garcia geschrieben:
> When block-commit is launched without the top parameter, it uses
> internally a mirror block job. In that case all intermediate nodes
> between the active and base nodes must be blocked as well.
> Signed-off-by: Alberto Garcia <address@hidden>

Same as the patch before, dataplane is okay because AioContexts are
switched together with the source image.

On second thought, however, maybe both places should set a blocker that
prevents attaching intermediate nodes to a new block device because you
can't read consistent data there. That's a preexisting problem, though,
and needs its own patch.

Reviewed-by: Kevin Wolf <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]