qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH] nbd: Use CoQueue for free_sema instead of CoMut


From: Paolo Bonzini
Subject: Re: [Qemu-block] [PATCH] nbd: Use CoQueue for free_sema instead of CoMutex
Date: Wed, 12 Oct 2016 12:53:32 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0


On 12/10/2016 12:18, Changlong Xie wrote:
> +    if (s->in_flight == MAX_NBD_REQUESTS) {
> +        qemu_co_queue_wait(&s->free_sema);
>          assert(s->in_flight < MAX_NBD_REQUESTS);
>      }

I was wondering if this should be a while loop instead, but the
assertion protects against that.  So:

Reviewed-by: Paolo Bonzini <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]