[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 0/2] qemu-img: change img_open() and opening met

From: Max Reitz
Subject: Re: [Qemu-block] [PATCH 0/2] qemu-img: change img_open() and opening method in dd
Date: Mon, 10 Oct 2016 22:00:32 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0

On 07.10.2016 17:36, Reda Sallahi wrote:
> The patch series include the previously submitted patch:
> [PATCH v5] qemu-img: change opening method for the output in dd
> Changes from v5:
> * Replace access() with a modified version of img_open() in img_dd()
> Depends on:
> [PATCH v3] qemu-img: add conv=notrunc option to dd

BTW, I didn't apply this patch so far because it actually doesn't
implement conv=notrunc. It makes specifying it mandatory, but when you
do, the output is still going to be truncated.

Patch 2 of this series fixes this, and while one normally says that
everything should work between patches as intended and not just after
applying the whole series, I'm fine with just applying that patch and
this series (once I think it's good) together as they are, because
getting everything in the right order would actually be rather
difficult, I think.

Also, you could argue that that patch fixes the "qemu-img dd does not
require conv=notrunc" "bug" and then patch 2 of this series fixes the
"qemu-img dd should not truncate an existing output file" "bug". So
since it is possible to argue that these patches fix two distinct bugs,
I think it should be fine to keep it broken in between...

tl;dr: I'll apply said patch together with this series once the latter
is in a good state.


> Reda Sallahi (2):
>   qemu-img: make img_open() able to surpress file opening errors
>   qemu-img: change opening method for the output in dd
>  qemu-img.c | 176 
> +++++++++++++++++++++++++++++++++++++------------------------
>  1 file changed, 106 insertions(+), 70 deletions(-)

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]