[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH] block: Remove "options" indirection from blockd

From: Max Reitz
Subject: Re: [Qemu-block] [PATCH] block: Remove "options" indirection from blockdev-add
Date: Fri, 7 Oct 2016 18:16:52 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0

On 07.10.2016 17:38, Kevin Wolf wrote:
> Now that QAPI supports boxed types, we can have unions at the top level
> of a command, so let's put our real options directly there for
> blockdev-add instead of having a single "options" dict that contains the
> real arguments.
> blockdev-add is still experimental and we already made substantial
> changes to the API recently, so we're free to make changes like this
> one, too.
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> Yes, that's right. Ignoring the test cases, this is a one-liner in
> the schema without any C code changes. :-)

While that is cool and correct, you also ignored the documentation
changes, which is probably not correct. :-)

(There are some blockdev-add examples in docs/qmp-commands.txt which
need to be adjusted.)


Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]