[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH] qcow2: Optimize L2 table cache size based on im

From: Alberto Garcia
Subject: Re: [Qemu-block] [PATCH] qcow2: Optimize L2 table cache size based on image and cluster sizes
Date: Fri, 07 Oct 2016 12:56:01 +0200
User-agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu)

On Fri 07 Oct 2016 10:14:32 AM CEST, Kevin Wolf wrote:

>> Maybe pass a negative integer to indicate percentage, so string is not 
>> required?:
>> l2-cache-size=-100    (l2-cache-size=max, covers entire drive)
>> l2-cache-size=-50     (l2-cache-size=50% of max, covers half of drive)
>> l2-cache-size=2097152 (l2-cache-size=2M)
> No, this is the kind of magic that is best to avoid.
> If you want to have two different ways to configure the cache, make it
> two different options.

I agree. Still, I would like to know what's the use case you (Frank, Ed)
are thinking about:

- Are we talking about command-line options, QMP, or both?
- Do you know the size of the disk image or you want to be able to set
  the cache size without having access to that information? In other
  words, what's preventing you from calculating the cache size that you


reply via email to

[Prev in Thread] Current Thread [Next in Thread]