[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v2 09/11] blockjob: add block_job_start

From: Kevin Wolf
Subject: Re: [Qemu-block] [PATCH v2 09/11] blockjob: add block_job_start
Date: Wed, 5 Oct 2016 17:17:06 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

Am 01.10.2016 um 00:00 hat John Snow geschrieben:
> Instead of automatically starting jobs at creation time via backup_start
> et al, we'd like to return a job object pointer that can be started
> manually at later point in time.
> For now, add the block_job_start mechanism and start the jobs
> automatically as we have been doing, with conversions job-by-job coming
> in later patches.
> Of note: cancellation of unstarted jobs will perform all the normal
> cleanup as if the job had started, particularly abort and clean. The
> only difference is that we will not emit any events, because the job
> never actually started.
> Signed-off-by: John Snow <address@hidden>

Should we make sure that jobs are only added to the block_jobs list once
they are started? It doesn't sound like a good idea to make a job
without a coroutine user-accessible.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]