[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH] Put the copyright information on a

From: Eric Blake
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH] Put the copyright information on a separate line
Date: Wed, 5 Oct 2016 08:03:57 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0

On 10/05/2016 04:54 AM, Thomas Huth wrote:
> The output string QEMU with "--version" is very long, it does
> not fit into a normal line of a terminal window anymore. By
> putting the copyright information on a separate line instead,
> the output looks much nicer.
> Signed-off-by: Thomas Huth <address@hidden>
> ---
>  Note: I'm not sure whether there is a technical or legal reason
>  that the copyright information has to be on the same line as the
>  version information, but if there is no such reason, I think
>  a separate line looks much nicer here.

There's precedent for separate lines of information (to wit, 'ls
--version' is the first thing I compared against), so I doubt there's
any legal reason (at any rate, if legality were an issue, I'm sure that
more programs would have run into that reason and adjusted to be
single-line output).  The only technical reason for a long line would be
for machine parsing, but we recommend (and libvirt uses) QMP for
machine-parseable version number information, rather than scraping
--version.  So I'm in favor of this.

Reviewed-by: Eric Blake <address@hidden>

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]