[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 1/1] qemu-iotests: update test 085.
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 1/1] qemu-iotests: update test 085.out with correct output |
Date: |
Tue, 4 Oct 2016 14:48:41 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 10/04/2016 12:22 PM, Jeff Cody wrote:
> Commit 5c678ee8d9406b9baeec788530965483575db555 changed the qmp
> dispatch and validation code, and the error output that test
> 085 relied on changed. Update it to be correct.
>
> Signed-off-by: Jeff Cody <address@hidden>
> ---
> tests/qemu-iotests/085.out | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Doesn't Marc-Andre's regression-fix followup patch series change the
wording right back, so that we wouldn't need this fix?
https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg08088.html
>
> diff --git a/tests/qemu-iotests/085.out b/tests/qemu-iotests/085.out
> index 08e4bb7..7a36117 100644
> --- a/tests/qemu-iotests/085.out
> +++ b/tests/qemu-iotests/085.out
> @@ -20,7 +20,7 @@ Formatting 'TEST_DIR/1-snapshot-v0.qcow2', fmt=qcow2
> size=134217728 backing_file
>
> === Invalid command - missing snapshot-file ===
>
> -{"error": {"class": "GenericError", "desc": "Parameter 'snapshot-file' is
> missing"}}
> +{"error": {"class": "GenericError", "desc": "Invalid parameter type for
> 'snapshot-file', expected: string"}}
>
>
> === Create several transactional group snapshots ===
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature