[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 04/10] block: Accept device model name for bl
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [PATCH v2 04/10] block: Accept device model name for blockdev-open/close-tray |
Date: |
Tue, 20 Sep 2016 13:05:34 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 19.09.2016 um 21:28 hat Eric Blake geschrieben:
> On 09/19/2016 11:54 AM, Kevin Wolf wrote:
> > In order to remove the necessity to use BlockBackend names in the
> > external API, we want to allow qdev device names in all device related
> > commands.
> >
> > This converts blockdev-open/close-tray to accept a qdev device name.
> >
> > Signed-off-by: Kevin Wolf <address@hidden>
> > ---
> > blockdev.c | 61
> > +++++++++++++++++++++++++++++++++++++++-------------
> > qapi/block-core.json | 14 ++++++++----
> > qmp-commands.hx | 16 ++++++++------
> > 3 files changed, 66 insertions(+), 25 deletions(-)
> >
>
> > +++ b/qmp-commands.hx
> > @@ -4295,7 +4295,7 @@ EQMP
> >
> > {
> > .name = "blockdev-open-tray",
> > - .args_type = "device:s,force:b?",
> > + .args_type = "device:s?,id:s?,force:b?",
> > .mhandler.cmd_new = qmp_marshal_blockdev_open_tray,
> > },
>
> Let the merge conflicts begin! Commit 33e1666b has landed.
Oh joy. I guess the rebase invalidates all of the R-bs, so I'll drop all
of them and resend a v3.
Kevin
pgpHtOp4g4Eyw.pgp
Description: PGP signature
- [Qemu-block] [PATCH v2 00/10] block: Accept qdev IDs in device level QMP commands, Kevin Wolf, 2016/09/19
- [Qemu-block] [PATCH v2 01/10] block: Add blk_by_dev(), Kevin Wolf, 2016/09/19
- [Qemu-block] [PATCH v2 02/10] qdev-monitor: Factor out find_device_state(), Kevin Wolf, 2016/09/19
- [Qemu-block] [PATCH v2 04/10] block: Accept device model name for blockdev-open/close-tray, Kevin Wolf, 2016/09/19
- [Qemu-block] [PATCH v2 03/10] qdev-monitor: Add blk_by_qdev_id(), Kevin Wolf, 2016/09/19
- [Qemu-block] [PATCH v2 05/10] block: Accept device model name for x-blockdev-insert-medium, Kevin Wolf, 2016/09/19
- [Qemu-block] [PATCH v2 06/10] block: Accept device model name for x-blockdev-remove-medium, Kevin Wolf, 2016/09/19
- [Qemu-block] [PATCH v2 08/10] block: Accept device model name for blockdev-change-medium, Kevin Wolf, 2016/09/19
- [Qemu-block] [PATCH v2 07/10] block: Accept device model name for eject, Kevin Wolf, 2016/09/19
- [Qemu-block] [PATCH v2 09/10] block: Accept device model name for block_set_io_throttle, Kevin Wolf, 2016/09/19