[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 3/7] block: Update bs->open_flags earlier in bdr
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-block] [PATCH 3/7] block: Update bs->open_flags earlier in bdrv_open_common() |
|
Date: |
Wed, 14 Sep 2016 18:42:20 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 14.09.2016 um 17:52 hat Alberto Garcia geschrieben:
> We're only doing this immediately before opening the image, but
> bs->open_flags is used earlier in the function. At the moment this is
> not causing problems because none of the checked flags are modified by
> update_flags_from_options(), but this will change when we introduce
> the "read-only" option.
>
> This patch calls update_flags_from_options() at the beginning of the
> function, immediately after creating the QemuOpts.
>
> Signed-off-by: Alberto Garcia <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
- [Qemu-block] [PATCH 0/7] Add "read-only" to the options QDict, Alberto Garcia, 2016/09/14
- [Qemu-block] [PATCH 6/7] commit: Add 'base' to the reopen queue before 'overlay_bs', Alberto Garcia, 2016/09/14
- [Qemu-block] [PATCH 1/7] block: Remove bdrv_is_snapshot, Alberto Garcia, 2016/09/14
- [Qemu-block] [PATCH 4/7] block: Add "read-only" to the options QDict, Alberto Garcia, 2016/09/14
- [Qemu-block] [PATCH 3/7] block: Update bs->open_flags earlier in bdrv_open_common(), Alberto Garcia, 2016/09/14
- Re: [Qemu-block] [PATCH 3/7] block: Update bs->open_flags earlier in bdrv_open_common(),
Kevin Wolf <=
- [Qemu-block] [PATCH 7/7] block: rename "read-only" to BDRV_OPT_READ_ONLY, Alberto Garcia, 2016/09/14
- [Qemu-block] [PATCH 2/7] block: Set BDRV_O_ALLOW_RDWR and snapshot_options before storing the flags, Alberto Garcia, 2016/09/14
- Re: [Qemu-block] [PATCH 2/7] block: Set BDRV_O_ALLOW_RDWR and snapshot_options before storing the flags, Kevin Wolf, 2016/09/14
- Re: [Qemu-block] [PATCH 2/7] block: Set BDRV_O_ALLOW_RDWR and snapshot_options before storing the flags, Alberto Garcia, 2016/09/15
- Re: [Qemu-block] [PATCH 2/7] block: Set BDRV_O_ALLOW_RDWR and snapshot_options before storing the flags, Kevin Wolf, 2016/09/15
- Re: [Qemu-block] [PATCH 2/7] block: Set BDRV_O_ALLOW_RDWR and snapshot_options before storing the flags, Alberto Garcia, 2016/09/15
- Re: [Qemu-block] [PATCH 2/7] block: Set BDRV_O_ALLOW_RDWR and snapshot_options before storing the flags, Kevin Wolf, 2016/09/15
- Re: [Qemu-block] [PATCH 2/7] block: Set BDRV_O_ALLOW_RDWR and snapshot_options before storing the flags, Alberto Garcia, 2016/09/15
Re: [Qemu-block] [PATCH 2/7] block: Set BDRV_O_ALLOW_RDWR and snapshot_options before storing the flags, Jeff Cody, 2016/09/14