[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v5 11/11] nbd-server: Allow node name for nbd-se
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH v5 11/11] nbd-server: Allow node name for nbd-server-add |
Date: |
Wed, 3 Aug 2016 18:36:25 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
On 03.08.2016 13:21, Kevin Wolf wrote:
> There is no reason why an NBD server couldn't be started for any node,
> even if it's not on the top level. This converts nbd-server-add to
> accept a node-name.
>
> Note that there is a semantic difference between using a BlockBackend
> name and the node name of its root: In the former case, the NBD server
> is closed on eject; in the latter case, the NBD server doesn't drop its
> reference and keeps the image file open this way.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> blockdev-nbd.c | 21 +++++++++------------
> qapi/block.json | 4 ++--
> 2 files changed, 11 insertions(+), 14 deletions(-)
As per the terms of surrender as stated on IRC:
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [PATCH v5 07/11] block: Accept node-name for change-backing-file, (continued)
- [Qemu-block] [PATCH v5 08/11] block: Accept node-name for drive-backup, Kevin Wolf, 2016/08/03
- [Qemu-block] [PATCH v5 09/11] block: Accept node-name for drive-mirror, Kevin Wolf, 2016/08/03
- [Qemu-block] [PATCH v5 10/11] nbd-server: Use a separate BlockBackend, Kevin Wolf, 2016/08/03
- [Qemu-block] [PATCH v5 11/11] nbd-server: Allow node name for nbd-server-add, Kevin Wolf, 2016/08/03
- Re: [Qemu-block] [PATCH v5 00/11] block: Accept node-name in all node level QMP commands, Kevin Wolf, 2016/08/08