Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/1] block: improve error handling in raw_open

[Markus Armbruster]

Max Reitz <address@hidden> writes:

> On 26.07.2016 19:18, Halil Pasic wrote:
[...]
>> Frankly, I'm a bit uncomfortable with asking (do not want to be pushy),
>> but do you have an opinion on the 'error_report_err' issue (pointed
>> out in the cover letter part)?
>
> You are using drive_add with QMP? As far as I know, one can only do so
> with human-monitor-command which returns the error string like so:
>
> {"return": "Could not open file: No such file or directory\r\n"}
>
> Apart from that, as for QMP, in theory you're supposed to use
> blockdev-add

In theory, we're supposed to have completed development of blockdev-add
into a useful, supported interface...

>              and device_add, I think (although blockdev-add is still
> considered experimental...).

... but we haven't, and that's why libvirt isn't using it, and you
shouldn't be using it, either.

>                              And blockdev-add will return the error
> string like so:
>
> {"error": {"class": "GenericError", "desc": "Could not open file: No
> such file or directory"}}