[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 1/2] crypto: add support for querying paramet
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v3 1/2] crypto: add support for querying parameters for block encryption |
Date: |
Fri, 15 Jul 2016 09:54:13 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 06/14/2016 10:33 AM, Max Reitz wrote:
> On 14.06.2016 18:24, Daniel P. Berrange wrote:
>> When creating new block encryption volumes, we accept a list of
>> parameters to control the formatting process. It is useful to
>> be able to query what those parameters were for existing block
>> devices. Add a qcrypto_block_get_info() method which returns a
>> QCryptoBlockInfo instance to report this data.
>>
>> Signed-off-by: Daniel P. Berrange <address@hidden>
>> ---
>> crypto/block-luks.c | 67 ++++++++++++++++++++++++++++++++++++++++++++
>> crypto/block.c | 17 +++++++++++
>> crypto/blockpriv.h | 4 +++
>> include/crypto/block.h | 16 +++++++++++
>> qapi/crypto.json | 76
>> ++++++++++++++++++++++++++++++++++++++++++++++++++
>> 5 files changed, 180 insertions(+)
>
> Reviewed-by: Max Reitz <address@hidden>
>
> (I'll be waiting whether Eric wants to comment)
Looks good to me as well; if you'd like you can add
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [PATCH v3 1/2] crypto: add support for querying parameters for block encryption,
Eric Blake <=