Re: [Qemu-block] [PATCH v3 01/11] block: Accept node-name for block-stream

[Eric Blake]

On 07/08/2016 04:01 AM, Kevin Wolf wrote:
> Am 08.07.2016 um 00:45 hat Eric Blake geschrieben:
>> On 07/07/2016 06:11 AM, Kevin Wolf wrote:
>>> In order to remove the necessity to use BlockBackend names in the
>>> external API, we want to allow node-names everywhere. This converts
>>> block-stream to accept a node-name without lifting the restriction that
>>> we're operating at a root node.
>>>
>>> In case of an invalid device name, the command returns the GenericError
>>> error class now instead of DeviceNotFound, because this is what
>>> qmp_get_root_bs() returns.
>>>
>>> Signed-off-by: Kevin Wolf <address@hidden>
>>> ---
>>>  blockdev.c             | 32 ++++++++++++++++++++------------
>>>  qapi/block-core.json   |  5 +----
>>>  qmp-commands.hx        |  2 +-
>>>  tests/qemu-iotests/030 |  2 +-
>>>  4 files changed, 23 insertions(+), 18 deletions(-)
>>>
>>
>> The interface change looks okay; but due to Berto's comments, I'm not
>> sure it is worth giving R-b yet if you plan on changing the check for
>> whether a node name properly qualifies as a root name.
> 
> Initially I intended to address the comment with some change, but since
> I realised that you already can put a BB everywhere and therefore this
> doesn't protect anything against intentional actions anyway, I'm not so
> sure any more.
> 
> Do you have an opintion on this? More input would be appreciated.

I still need to re-read the other sub-thread closely, but yes, I'll try
to chime in after I've had a chance to think about implications.


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature