[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 4/7] block: remove extra condition in bdrv_ca
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v2 4/7] block: remove extra condition in bdrv_can_write_zeroes_with_unmap |
Date: |
Thu, 7 Jul 2016 17:09:16 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 07/07/2016 03:35 AM, Denis V. Lunev wrote:
> All nowadays .bdrv_co_write_zeroes callbacks could perfectly work even
Grammar:
All .bdrv_co_write_zeroes callbacks nowadays work perfectly even...
> with backing store attached. If future new callbacks will unable to do
s/will/would be/
> that - they have a chance to block this in bdrv_get_info().
>
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Stefan Hajnoczi <address@hidden>
> CC: Fam Zheng <address@hidden>
> CC: Kevin Wolf <address@hidden>
> CC: Max Reitz <address@hidden>
> CC: Jeff Cody <address@hidden>
> CC: Eric Blake <address@hidden>
> ---
> block.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block.c b/block.c
> index 823ff1d..c2fb8bd 100644
> --- a/block.c
> +++ b/block.c
> @@ -2834,7 +2834,7 @@ bool bdrv_can_write_zeroes_with_unmap(BlockDriverState
> *bs)
> {
> BlockDriverInfo bdi;
>
> - if (bs->backing || !(bs->open_flags & BDRV_O_UNMAP)) {
> + if (!(bs->open_flags & BDRV_O_UNMAP)) {
> return false;
> }
>
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v2 5/7] mirror: optimize dirty bitmap filling in mirror_run a bit, (continued)
- [Qemu-block] [PATCH v2 5/7] mirror: optimize dirty bitmap filling in mirror_run a bit, Denis V. Lunev, 2016/07/07
- [Qemu-block] [PATCH v2 3/7] mirror: create mirror_dirty_init helper for mirror_run, Denis V. Lunev, 2016/07/07
- [Qemu-block] [PATCH v2 1/7] dirty-bitmap: operate with int64_t amount, Denis V. Lunev, 2016/07/07
- [Qemu-block] [PATCH v2 4/7] block: remove extra condition in bdrv_can_write_zeroes_with_unmap, Denis V. Lunev, 2016/07/07
- [Qemu-block] [PATCH v2 7/7] mirror: improve performance of mirroring of empty disk, Denis V. Lunev, 2016/07/07
- [Qemu-block] [PATCH v2 2/7] mirror: make sectors_in_flight int64_t, Denis V. Lunev, 2016/07/07
- Re: [Qemu-block] [PATCH v2 0/7] drive-mirror improvements, Fam Zheng, 2016/07/12