[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 05/15] blockjob: Add 'job_id' parameter to bl
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [PATCH v2 05/15] blockjob: Add 'job_id' parameter to block_job_create() |
Date: |
Wed, 22 Jun 2016 15:10:10 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 22.06.2016 um 14:25 hat Alberto Garcia geschrieben:
> Job IDs are generated automatically when a new job is created. This
> patch adds a new 'job_id' parameter to let the caller provide one
> instead. In this case the ID is verified to be unique and well-formed.
>
> Signed-off-by: Alberto Garcia <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>
> @@ -140,7 +151,7 @@ void *block_job_create(const BlockJobDriver *driver,
> BlockDriverState *bs,
>
> job->driver = driver;
> job->device = g_strdup(bdrv_get_device_name(bs));
> - job->id = id_generate(ID_JOB);
> + job->id = job_id ? g_strdup(job_id) : id_generate(ID_JOB);
> job->blk = blk;
> job->cb = cb;
> job->opaque = opaque;
This hunk will trivially conflict with removing device names. You can
keep my R-b while resolving that.
Reviewed-by: Kevin Wolf <address@hidden>
- [Qemu-block] [PATCH v2 00/15] Add an 'id' field to block jobs, Alberto Garcia, 2016/06/22
- [Qemu-block] [PATCH v2 01/15] stream: Fix prototype of stream_start(), Alberto Garcia, 2016/06/22
- [Qemu-block] [PATCH v2 03/15] blockjob: Add block_job_get(), Alberto Garcia, 2016/06/22
- [Qemu-block] [PATCH v2 07/15] backup: Add 'job-id' parameter to 'blockdev-backup' and 'drive-backup', Alberto Garcia, 2016/06/22
- [Qemu-block] [PATCH v2 06/15] mirror: Add 'job-id' parameter to 'blockdev-mirror' and 'drive-mirror', Alberto Garcia, 2016/06/22
- [Qemu-block] [PATCH v2 08/15] stream: Add 'job-id' parameter to 'block-stream', Alberto Garcia, 2016/06/22
- [Qemu-block] [PATCH v2 05/15] blockjob: Add 'job_id' parameter to block_job_create(), Alberto Garcia, 2016/06/22
- Re: [Qemu-block] [PATCH v2 05/15] blockjob: Add 'job_id' parameter to block_job_create(),
Kevin Wolf <=
- [Qemu-block] [PATCH v2 02/15] blockjob: Decouple the ID from the device name in the BlockJob struct, Alberto Garcia, 2016/06/22
- Re: [Qemu-block] [PATCH v2 02/15] blockjob: Decouple the ID from the device name in the BlockJob struct, Kevin Wolf, 2016/06/22
- Re: [Qemu-block] [PATCH v2 02/15] blockjob: Decouple the ID from the device name in the BlockJob struct, Alberto Garcia, 2016/06/22
- Re: [Qemu-block] [PATCH v2 02/15] blockjob: Decouple the ID from the device name in the BlockJob struct, Kevin Wolf, 2016/06/22
- Re: [Qemu-block] [PATCH v2 02/15] blockjob: Decouple the ID from the device name in the BlockJob struct, Alberto Garcia, 2016/06/23
- Re: [Qemu-block] [PATCH v2 02/15] blockjob: Decouple the ID from the device name in the BlockJob struct, Max Reitz, 2016/06/29
- Re: [Qemu-block] [PATCH v2 02/15] blockjob: Decouple the ID from the device name in the BlockJob struct, Alberto Garcia, 2016/06/30
[Qemu-block] [PATCH v2 09/15] commit: Add 'job-id' parameter to 'block-commit', Alberto Garcia, 2016/06/22
[Qemu-block] [PATCH v2 14/15] blockjob: Add 'id' parameter to 'block-job-complete', Alberto Garcia, 2016/06/22
[Qemu-block] [PATCH v2 04/15] block: Simplify find_block_job() and make it accept a job ID, Alberto Garcia, 2016/06/22