[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 04/15] block: Simplify find_block_job() and make
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-block] [PATCH 04/15] block: Simplify find_block_job() and make it accept a job ID |
Date: |
Tue, 21 Jun 2016 14:59:49 +0200 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Mon 20 Jun 2016 06:40:31 PM CEST, Max Reitz wrote:
>> + error_setg(errp, "Block job '%s' not found", id ? id : device);
>
> This changes the error class if device is set. Not sure if that is
> bad, but keeping the old behavior should be simple (unless you're sure
> it's fine).
You're right, I'll fix it.
> Also, but this is a personal opinion, I'd make the error path more
> explicit, i.e.:
>
> if (!job) {
> /* ... */
> return NULL;
> }
Yeah, why not.
Berto
- [Qemu-block] [PATCH 11/15] blockjob: Add 'id' parameter to 'block-job-cancel', (continued)
[Qemu-block] [PATCH 12/15] blockjob: Add 'id' parameter to 'block-job-pause', Alberto Garcia, 2016/06/09