[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 03/13] vmport: identify vmport type by macro TYP
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-block] [PATCH 03/13] vmport: identify vmport type by macro TYPE_VMPORT |
Date: |
Fri, 17 Jun 2016 15:19:18 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 |
On 17/06/2016 15:10, Efimov Vasily wrote:
> Currently vmport device is identified by the string literal. Using a
> preprocessor alias instead is preferable.
>
> Signed-off-by: Efimov Vasily <address@hidden>
> ---
> hw/misc/vmport.c | 1 -
> include/hw/i386/pc.h | 3 ++-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/misc/vmport.c b/hw/misc/vmport.c
> index 6896789..c763811 100644
> --- a/hw/misc/vmport.c
> +++ b/hw/misc/vmport.c
> @@ -36,7 +36,6 @@
> #define VMPORT_ENTRIES 0x2c
> #define VMPORT_MAGIC 0x564D5868
>
> -#define TYPE_VMPORT "vmport"
> #define VMPORT(obj) OBJECT_CHECK(VMPortState, (obj), TYPE_VMPORT)
>
> typedef struct VMPortState
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index 9ca2309..aab3a53 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
> @@ -199,11 +199,12 @@ typedef struct GSIState {
> void gsi_handler(void *opaque, int n, int level);
>
> /* vmport.c */
> +#define TYPE_VMPORT "vmport"
> typedef uint32_t (VMPortReadFunc)(void *opaque, uint32_t address);
>
> static inline void vmport_init(ISABus *bus)
> {
> - isa_create_simple(bus, "vmport");
> + isa_create_simple(bus, TYPE_VMPORT);
> }
>
> void vmport_register(unsigned char command, VMPortReadFunc *func, void
> *opaque);
>
Reviewed-by: Paolo Bonzini <address@hidden>
- [Qemu-block] [PATCH 00/13] Make Q35 devices closer to Qemu object model., Efimov Vasily, 2016/06/17
- [Qemu-block] [PATCH 03/13] vmport: identify vmport type by macro TYPE_VMPORT, Efimov Vasily, 2016/06/17
- Re: [Qemu-block] [PATCH 03/13] vmport: identify vmport type by macro TYPE_VMPORT,
Paolo Bonzini <=
- [Qemu-block] [PATCH 04/13] pflash: make TYPE_CFI_PFLASH0{1, 2} macros public, Efimov Vasily, 2016/06/17
- [Qemu-block] [PATCH 12/13] MC146818 RTC: add GPIO access to output IRQ, Efimov Vasily, 2016/06/17
- [Qemu-block] [PATCH 01/13] ide: move headers to include folder, Efimov Vasily, 2016/06/17
- [Qemu-block] [PATCH 09/13] ICH9 SMB: make TYPE_ICH9_SMB_DEVICE macro public, Efimov Vasily, 2016/06/17
- [Qemu-block] [PATCH 10/13] ICH9 LPC: handle PIC and I/O APIC IRQs as qdev GPIO, Efimov Vasily, 2016/06/17