[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 1/6] doc: move text describing --trace to specif
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH 1/6] doc: move text describing --trace to specific .texi file |
Date: |
Mon, 13 Jun 2016 13:37:01 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 06/13/2016 10:58 AM, Denis V. Lunev wrote:
> This text will be included to qemu-nbd/qemu-img mans in the next patches.
>
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Eric Blake <address@hidden>
> CC: Paolo Bonzini <address@hidden>
> CC: Stefan Hajnoczi <address@hidden>
> CC: Kevin Wolf <address@hidden>
> ---
> +++ b/qemu-option-trace.texi
> @@ -0,0 +1,27 @@
> address@hidden -trace
> +
I think the @findex entry should remain per-file, and not in the include
(since the other executables will spell it '--trace', and only qemu
proper accepts the shorthand '-trace').
> +++ b/qemu-options.hx
> @@ -3661,33 +3661,7 @@ STEXI
> HXCOMM This line is not accurate, as some sub-options are backend-specific
> but
> HXCOMM HX does not support conditional compilation of text.
> @item -trace address@hidden,address@hidden
> address@hidden -trace
Otherwise, it looks fine to me.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v4 0/6] trace: enable tracing in qemu-io/qemu-nbd/qemu-img, Denis V. Lunev, 2016/06/13
- [Qemu-block] [PATCH 5/6] qemu-img: move common options parsing before commands processing, Denis V. Lunev, 2016/06/13
- [Qemu-block] [PATCH 4/6] trace: enable tracing in qemu-nbd, Denis V. Lunev, 2016/06/13
- [Qemu-block] [PATCH 1/6] doc: move text describing --trace to specific .texi file, Denis V. Lunev, 2016/06/13
- Re: [Qemu-block] [PATCH 1/6] doc: move text describing --trace to specific .texi file,
Eric Blake <=
- [Qemu-block] [PATCH 3/6] trace: enable tracing in qemu-io, Denis V. Lunev, 2016/06/13
- [Qemu-block] [PATCH 2/6] trace: move qemu_trace_opts to trace/control.c, Denis V. Lunev, 2016/06/13
- [Qemu-block] [PATCH 6/6] trace: enable tracing in qemu-img, Denis V. Lunev, 2016/06/13