[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v4 00/11] nbd: tighter protocol compliance
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-block] [PATCH v4 00/11] nbd: tighter protocol compliance |
Date: |
Mon, 13 Jun 2016 18:28:19 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 |
On 12/05/2016 00:39, Eric Blake wrote:
> Fix several corner-case bugs in our implementation of the NBD
> protocol, both as client and as server.
>
> Depends on Kevin's block-next branch:
> git://repo.or.cz/qemu/kevin.git block-next
>
> Also available as a tag at this location:
> git fetch git://repo.or.cz/qemu/ericb.git nbd-flags-v4
>
> Broken out of a larger v3 series[1], for easier review. There
> are still some places where we aren't quite compliant (for example,
> the protocol recommends that the client send NBD_OPT_ABORT before
> dropping the connection after receiving a valid server response it
> didn't like but which did not violate protocol), but later series
> will tackle that.
>
> [1] https://lists.gnu.org/archive/html/qemu-devel/2016-04/msg03526.html
>
> Changes in v4: rebase to latest block-next
>
> 001/11:[----] [--] 'nbd: Use BDRV_REQ_FUA for better FUA where supported'
Applied.
> 002/11:[0004] [FC] 'nbd: More debug typo fixes, use correct formats'
Applied.
> 003/11:[----] [--] 'nbd: Quit server after any write error'
Applied.
> 004/11:[----] [--] 'nbd: Improve server handling of bogus commands'
Applied with some changes, see reply to individual patch.
> 005/11:[----] [--] 'nbd: Reject unknown request flags'
Applied.
> 006/11:[----] [--] 'nbd: Group all Linux-specific ioctl code in one place'
Applied.
> 007/11:[----] [--] 'nbd: Clean up ioctl handling of qemu-nbd -c'
Applied.
> 008/11:[----] [-C] 'nbd: Limit nbdflags to 16 bits'
Doesn't apply anymore.
> 009/11:[----] [--] 'nbd: Add qemu-nbd -D for human-readable description'
Doesn't apply anymore.
> 010/11:[----] [--] 'nbd: Detect servers that send unexpected error values'
Applied.
> 011/11:[----] [--] 'nbd: Avoid magic number for NBD max name size'
Applied.
I'll need a v5 of just patch 8 and patch 9; I'm queuing the rest and
will send a pull request later this week.
Thanks,
Paolo
- Re: [Qemu-block] [PATCH v4 00/11] nbd: tighter protocol compliance,
Paolo Bonzini <=