[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v6 08/22] raw-posix: Add image lock
From: |
Fam Zheng |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v6 08/22] raw-posix: Add image locking support |
Date: |
Sat, 4 Jun 2016 07:53:51 +0800 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Fri, 06/03 16:49, Fam Zheng wrote:
> +static
> +int raw_reopen_downgrade(BDRVReopenState *state,
> + RawReopenOperation op,
> + BdrvLockfCmd old_lock,
> + BdrvLockfCmd new_lock,
> + Error **errp)
> +{
> + BDRVRawReopenState *raw_s = state->opaque;
> + BDRVRawState *s = state->bs->opaque;
> + int ret;
This should be initialized to 0 for the nop branches.
Fam
> +
> + assert(old_lock == BDRV_LOCKF_EXCLUSIVE);
> + assert(new_lock == BDRV_LOCKF_SHARED);
> + switch (op) {
> + case RAW_REOPEN_PREPARE:
> + break;
> + case RAW_REOPEN_COMMIT:
> + ret = raw_lockf_fd(s->lock_fd, BDRV_LOCKF_SHARED);
> + if (ret) {
> + error_report("Failed to downgrade old lock");
> + break;
> + }
> + ret = raw_lockf_fd(raw_s->lock_fd, BDRV_LOCKF_SHARED);
> + if (ret) {
> + error_report("Failed to lock new fd");
> + break;
> + }
> + break;
> + case RAW_REOPEN_ABORT:
> + break;
> + }
> +
> + return ret;
> +}
- Re: [Qemu-block] [PATCH v6 05/22] osdep: Add qemu_lock_fd and qemu_unlock_fd, (continued)
[Qemu-block] [PATCH v6 07/22] raw-posix: Use qemu_dup, Fam Zheng, 2016/06/03
[Qemu-block] [PATCH v6 06/22] osdep: Introduce qemu_dup, Fam Zheng, 2016/06/03
[Qemu-block] [PATCH v6 09/22] qemu-io: Add "-L" option for BDRV_O_NO_LOCK, Fam Zheng, 2016/06/03
[Qemu-block] [PATCH v6 08/22] raw-posix: Add image locking support, Fam Zheng, 2016/06/03
[Qemu-block] [PATCH v6 10/22] qemu-img: Add "-L" option to sub commands, Fam Zheng, 2016/06/03
[Qemu-block] [PATCH v6 12/22] qemu-nbd: Add "--no-lock/-L" option, Fam Zheng, 2016/06/03
[Qemu-block] [PATCH v6 11/22] qemu-img: Update documentation of "-L" option, Fam Zheng, 2016/06/03
[Qemu-block] [PATCH v6 13/22] block: Don't lock drive-backup target image in none mode, Fam Zheng, 2016/06/03
[Qemu-block] [PATCH v6 14/22] mirror: Disable image locking on target backing chain, Fam Zheng, 2016/06/03
[Qemu-block] [PATCH v6 15/22] qemu-iotests: 046: Move version detection out from verify_io, Fam Zheng, 2016/06/03