[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] m25p80: fix test on blk_pread() return value
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-block] [PATCH] m25p80: fix test on blk_pread() return value |
|
Date: |
Tue, 31 May 2016 08:26:23 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 05/31/2016 05:36 AM, Cédric Le Goater wrote:
> commit 243e6f69c129 ("m25p80: Switch to byte-based block access")
> replaced blk_read() calls with blk_pread() but return values are
> different.
Shoot, I completely missed that when I made the conversions. Now I need
to re-audit that entire series to see if the same problem happened
anywhere else.
>
> Signed-off-by: Cédric Le Goater <address@hidden>
> ---
> hw/block/m25p80.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
>
> Index: qemu-ast2400-mainline.git/hw/block/m25p80.c
> ===================================================================
> --- qemu-ast2400-mainline.git.orig/hw/block/m25p80.c
> +++ qemu-ast2400-mainline.git/hw/block/m25p80.c
> @@ -900,7 +900,7 @@ static int m25p80_init(SSISlave *ss)
> s->storage = blk_blockalign(s->blk, s->size);
>
> /* FIXME: Move to late init */
> - if (blk_pread(s->blk, 0, s->storage, s->size)) {
> + if (blk_pread(s->blk, 0, s->storage, s->size) != s->size) {
> fprintf(stderr, "Failed to initialize SPI flash!\n");
> return 1;
> }
>
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature