[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v19 08/10] Implement new driver for block replic
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-block] [PATCH v19 08/10] Implement new driver for block replication |
Date: |
Mon, 30 May 2016 11:14:16 -0700 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Fri, May 20, 2016 at 03:36:18PM +0800, Changlong Xie wrote:
> + /* start backup job now */
> + error_setg(&s->blocker,
> + "block device is in use by internal backup job");
> +
> + top_bs = bdrv_lookup_bs(s->top_id, s->top_id, errp);
> + if (!top_bs || !check_top_bs(top_bs, bs)) {
> + reopen_backing_file(s, false, NULL);
> + aio_context_release(aio_context);
> + return;
> + }
Missing error_setg() with an error message when check_top_bs() fails.
signature.asc
Description: PGP signature
- [Qemu-block] [PATCH v19 07/10] Introduce new APIs to do replication operation, (continued)
- [Qemu-block] [PATCH v19 07/10] Introduce new APIs to do replication operation, Changlong Xie, 2016/05/20
- [Qemu-block] [PATCH v19 01/10] unblock backup operations in backing file, Changlong Xie, 2016/05/20
- [Qemu-block] [PATCH v19 05/10] docs: block replication's description, Changlong Xie, 2016/05/20
- [Qemu-block] [PATCH v19 03/10] Backup: export interfaces for extra serialization, Changlong Xie, 2016/05/20
- [Qemu-block] [PATCH v19 09/10] tests: add unit test case for replication, Changlong Xie, 2016/05/20
- [Qemu-block] [PATCH v19 06/10] auto complete active commit, Changlong Xie, 2016/05/20
- [Qemu-block] [PATCH v19 08/10] Implement new driver for block replication, Changlong Xie, 2016/05/20
- Re: [Qemu-block] [PATCH v19 08/10] Implement new driver for block replication,
Stefan Hajnoczi <=
- [Qemu-block] [PATCH v19 10/10] support replication driver in blockdev-add, Changlong Xie, 2016/05/20
- Re: [Qemu-block] [PATCH v19 00/10] Block replication for continuous checkpoints, Changlong Xie, 2016/05/26
- Re: [Qemu-block] [PATCH v19 00/10] Block replication for continuous checkpoints, Stefan Hajnoczi, 2016/05/30