[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v5 07/27] block: Handle image locking during reo
|
From: |
Max Reitz |
|
Subject: |
Re: [Qemu-block] [PATCH v5 07/27] block: Handle image locking during reopen |
|
Date: |
Fri, 27 May 2016 11:57:42 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 |
On 27.05.2016 09:48, Fam Zheng wrote:
> On Tue, 05/24 18:28, Max Reitz wrote:
[...]
>> Also: Should bdrv_reopen_prepare() check that the locking flags are not
>> changed?
>
> Read only flag also matters in fcntl locks, so practically we almost always
> need some change on the lock.
Hm, but as far as I can see, you don't handle changed locking flags
here; the reopened image is just locked if the old one had been locked
before. Since the handling of BDRV_O_SHARED_LOCK is done in
bdrv_lock_unlock_image_do(), that means that BDRV_O_NO_LOCK is ignored
if changed, isn't it?
Max
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v5 04/27] block: Introduce image file locking, (continued)
[Qemu-block] [PATCH v5 08/27] osdep: Add qemu_lock_fd and qemu_unlock_fd, Fam Zheng, 2016/05/17
[Qemu-block] [PATCH v5 11/27] raw-posix: Implement .bdrv_lockf, Fam Zheng, 2016/05/17
[Qemu-block] [PATCH v5 09/27] osdep: Introduce qemu_dup, Fam Zheng, 2016/05/17
[Qemu-block] [PATCH v5 10/27] raw-posix: Use qemu_dup, Fam Zheng, 2016/05/17