[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v5 27/27] qemu-iotests: Add test case 153 for im
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH v5 27/27] qemu-iotests: Add test case 153 for image locking |
Date: |
Wed, 25 May 2016 16:20:28 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 |
On 17.05.2016 09:35, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> tests/qemu-iotests/153 | 197 +++++++++++++++++++++
> tests/qemu-iotests/153.out | 426
> +++++++++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/group | 1 +
> 3 files changed, 624 insertions(+)
> create mode 100755 tests/qemu-iotests/153
> create mode 100644 tests/qemu-iotests/153.out
>
> diff --git a/tests/qemu-iotests/153 b/tests/qemu-iotests/153
> new file mode 100755
> index 0000000..cbeda8e
> --- /dev/null
> +++ b/tests/qemu-iotests/153
[...]
> +for opts1 in "" "readonly=on" "lock-mode=off" "lock-mode=shared"; do
> + echo
> + echo "== Creating base image =="
> + TEST_IMG="${TEST_IMG}.base" _make_test_img $size
> +
> + echo
> + echo "== Creating test image =="
> + $QEMU_IMG create -f $IMGFMT "${TEST_IMG}" -b ${TEST_IMG}.base |
> _filter_img_create
_make_test_img understands -b, so maybe you want to use it here.
Also I'm not sure why you're creating the images inside of this loop,
but it certainly isn't wrong.
But maybe you want to add a line that echos $opts1 somewhere here.
However you decide:
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [PATCH v5 23/27] iotests: 087: Disable image lock in cases where file is shared, (continued)
- [Qemu-block] [PATCH v5 22/27] qemu-iotests: 030: Disable image lock when checking test image, Fam Zheng, 2016/05/17
- [Qemu-block] [PATCH v5 24/27] iotests: Disable image locking in 085, Fam Zheng, 2016/05/17
- [Qemu-block] [PATCH v5 25/27] tests: Use null-co:// instead of /dev/null, Fam Zheng, 2016/05/17
- [Qemu-block] [PATCH v5 26/27] block: Turn on image locking by default, Fam Zheng, 2016/05/17
- [Qemu-block] [PATCH v5 27/27] qemu-iotests: Add test case 153 for image locking, Fam Zheng, 2016/05/17
- Re: [Qemu-block] [PATCH v5 27/27] qemu-iotests: Add test case 153 for image locking,
Max Reitz <=
- Re: [Qemu-block] [Qemu-devel] [PATCH v5 00/27] block: Lock images when opening, Richard W.M. Jones, 2016/05/24