[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 05/13] block: Move throttling fields from BDS
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [PATCH v2 05/13] block: Move throttling fields from BDS to BB |
Date: |
Wed, 11 May 2016 14:45:40 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 09.05.2016 um 14:43 hat Stefan Hajnoczi geschrieben:
> On Fri, Apr 22, 2016 at 07:42:34PM +0200, Kevin Wolf wrote:
> > @@ -1527,7 +1525,7 @@ static int bdrv_open_inherit(BlockDriverState **pbs,
> > const char *filename,
> > return -ENODEV;
> > }
> >
> > - if (bs->throttle_state) {
> > + if (blk_get_public(bs->blk)->throttle_state) {
>
> The reference argument can be any nodename. How can you be sure bs->blk
> != NULL?
Good catch, this should check bs->blk != NULL first. This check goes
away later in series, but I'll fix it anyway.
Kevin
pgpsTd0bizdTY.pgp
Description: PGP signature