[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH for-2.6 1/2] block/mirror: Revive dead yielding
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [PATCH for-2.6 1/2] block/mirror: Revive dead yielding code |
Date: |
Wed, 20 Apr 2016 14:15:37 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 20.04.2016 um 00:59 hat Max Reitz geschrieben:
> mirror_iteration() is supposed to wait if the current chunk is subject
> to a still in-flight mirroring operation. However, it mixed checking
> this conflict situation with checking the dirty status of a chunk. A
> simplification for the latter condition (the first chunk encountered is
> always dirty) led to neglecting the former: We just skip the first chunk
> and thus never test whether it conflicts with an in-flight operation.
>
> To fix this, pull out the code which waits for in-flight operations on
> the first chunk of the range to be mirrored to settle.
>
> Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>