[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 04/14] block: Add blk_name_taken()
|
From: |
Max Reitz |
|
Subject: |
Re: [Qemu-block] [PATCH v3 04/14] block: Add blk_name_taken() |
|
Date: |
Wed, 17 Feb 2016 16:36:29 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 |
On 17.02.2016 11:29, Kevin Wolf wrote:
> Am 16.02.2016 um 19:08 hat Max Reitz geschrieben:
>> There may be BlockBackends which are not returned by blk_by_name(), but
>> do exist and have a name.
>
> Really? And if so, isn't this a bug?
Depends on your definition of what the name is. :-)
As you said on IRC, denoting the monitor reference by that name seems
reasonable, so in that case it would be wrong behavior indeed.
> I expect that a BB is always either visible to the user and has a name
> that is resolved to this BB everywhere, or it's entirely internal and
> doesn't need a name therefore.
>
> Having a BB that is internal and therefore invisble, but has a name and
> prevents the creation of another BB or BDS with the same name, must
> certainly be confusing for the user.
Yep, will change.
Max
>> blk_name_taken() allows testing whether a
>> specific name is in use already, independent of whether the BlockBackend
>> with that name is accessible through blk_by_name().
>>
>> Signed-off-by: Max Reitz <address@hidden>
>
> Kevin
>
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v3 00/14] blockdev: Further BlockBackend work, Max Reitz, 2016/02/16
- [Qemu-block] [PATCH v3 02/14] block: Use blk_next() where appropriate, Max Reitz, 2016/02/16
- [Qemu-block] [PATCH v3 01/14] monitor: Use BB list for BB name completion, Max Reitz, 2016/02/16
- [Qemu-block] [PATCH v3 03/14] block: Add blk_all_next(), Max Reitz, 2016/02/16
- [Qemu-block] [PATCH v3 05/14] block: Add blk_commit_all(), Max Reitz, 2016/02/16
- [Qemu-block] [PATCH v3 06/14] block: Use blk_{commit, flush}_all() consistently, Max Reitz, 2016/02/16
- [Qemu-block] [PATCH v3 04/14] block: Add blk_name_taken(), Max Reitz, 2016/02/16
- [Qemu-block] [PATCH v3 08/14] blockdev: Remove blk_hide_on_behalf_of_hmp_drive_del(), Max Reitz, 2016/02/16
- [Qemu-block] [PATCH v3 07/14] blockdev: Add list of monitor-owned BlockBackends, Max Reitz, 2016/02/16