[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v6 00/16] Implement TLS support to
From: |
Kashyap Chamarthy |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v6 00/16] Implement TLS support to QEMU NBD server & client |
Date: |
Fri, 12 Feb 2016 17:03:07 +0100 |
User-agent: |
Mutt/1.5.23.1 (2014-03-12) |
On Fri, Feb 12, 2016 at 03:00:32PM +0000, Daniel P. Berrange wrote:
> On Fri, Feb 12, 2016 at 02:28:33PM +0100, Kashyap Chamarthy wrote:
> > On Wed, Feb 10, 2016 at 06:40:58PM +0000, Daniel P. Berrange wrote:
> >
> > [...]
> >
> > I've applied all the series in this patches,
s/series in this patches/patches in this series/
> > to yesterday's Git master,
> > so I'm here:
> >
> > $ git describe
> > pull-qcrypto-next-2016-02-02-1-378-gf9375d2
> >
[...]
> > > $ qmp-shell /tmp/qmp
> > > (qmp) nbd-server-start addr={"host":"localhost","port":"9000"}
> > > tls-creds=tls0
> >
> > However, this invocation seem to work for me, am I doing something
Typo: s/seem to work/doesn't seem to work/
> > wrong?
> >
> > $ ./qmp-shell ./qmp-sock
> > Welcome to the QMP low-level shell!
> > Connected to QEMU 2.5.50
> >
> > (QEMU) nbd-server-start addr={'host:'localhost','port':'9000'}
> > tls-creds=tls0
> > {"error": {"class": "GenericError", "desc": "Invalid parameter type for
> > 'addr', expected: QDict"}}
> > (QEMU)
>
> Yes, my bad - I provided the wrong syntax here. it should be
>
> (QEMU) nbd-server-start
> addr={"type":"inet","data":{"host":"localhost","port":"9000"}} tls-creds=tls0
> {"return": {}}
> (QEMU) nbd-server-add device=ide0-hd0
> {"return": {}}
>
> I've genuinely tested it this time :-)
Heh, right, this works. I should've figured this out, given that I've
already used it in the complete JSON invocation in my previous email.
[...] "addr":{"type":"inet","data":{"host":"localhost","port":"9000"}}[...]
So, 'qmp-shell' invocation works for me too:
$ ./qmp-shell ./qmp-sock
[...]
(QEMU) nbd-server-start
addr={"type":"inet","data":{"host":"localhost","port":"9000"}} tls-creds=tls0
{"return": {}}
(QEMU)
(QEMU) nbd-server-add device=virtio0
{"return": {}}
(QEMU)
--
/kashyap
- [Qemu-block] [PATCH v6 09/16] nbd: make client request fixed new style if advertized, (continued)
- [Qemu-block] [PATCH v6 09/16] nbd: make client request fixed new style if advertized, Daniel P. Berrange, 2016/02/10
- [Qemu-block] [PATCH v6 10/16] nbd: allow setting of an export name for qemu-nbd server, Daniel P. Berrange, 2016/02/10
- [Qemu-block] [PATCH v6 11/16] nbd: always query export list in fixed new style protocol, Daniel P. Berrange, 2016/02/10
- [Qemu-block] [PATCH v6 12/16] nbd: use "" as a default export name if none provided, Daniel P. Berrange, 2016/02/10
- [Qemu-block] [PATCH v6 14/16] nbd: enable use of TLS with NBD block driver, Daniel P. Berrange, 2016/02/10
- [Qemu-block] [PATCH v6 15/16] nbd: enable use of TLS with qemu-nbd server, Daniel P. Berrange, 2016/02/10
- [Qemu-block] [PATCH v6 13/16] nbd: implement TLS support in the protocol negotiation, Daniel P. Berrange, 2016/02/10
- [Qemu-block] [PATCH v6 16/16] nbd: enable use of TLS with nbd-server-start command, Daniel P. Berrange, 2016/02/10
- Re: [Qemu-block] [Qemu-devel] [PATCH v6 00/16] Implement TLS support to QEMU NBD server & client, Kashyap Chamarthy, 2016/02/12
- Re: [Qemu-block] [PATCH v6 00/16] Implement TLS support to QEMU NBD server & client, Paolo Bonzini, 2016/02/16