[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v2 2/2] block: Update the x-blockdev-del documentati
From: |
Alberto Garcia |
Subject: |
[Qemu-block] [PATCH v2 2/2] block: Update the x-blockdev-del documentation |
Date: |
Tue, 9 Feb 2016 17:57:36 +0200 |
Explain what happens if the user tries to delete a BlockBackend that
contains media that was added separately using blockdev-add.
Signed-off-by: Alberto Garcia <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
qapi/block-core.json | 5 ++++-
qmp-commands.hx | 5 ++++-
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 33012b8..cc59ab9 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -2089,7 +2089,10 @@
#
# In the former case the backend will be destroyed, along with its
# inserted medium if there's any. The command will fail if the backend
-# or its medium are in use.
+# or its medium are in use. If the medium was also created with
+# blockdev-add then the command will succeed, the backend will be
+# destroyed but the medium will remain until it is deleted with
+# x-blockdev-del.
#
# In the latter case the node will be destroyed. The command will fail
# if the node is attached to a block backend or is otherwise being
diff --git a/qmp-commands.hx b/qmp-commands.hx
index 020e5ee..9710686 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -4151,7 +4151,10 @@ The selected device can be either a block backend or a
graph node.
In the former case the backend will be destroyed, along with its
inserted medium if there's any. The command will fail if the backend
-or its medium are in use.
+or its medium are in use. If the medium was also created with
+blockdev-add then the command will succeed, the backend will be
+destroyed but the medium will remain until it is deleted with
+x-blockdev-del.
In the latter case the node will be destroyed. The command will fail
if the node is attached to a block backend or is otherwise being
--
2.7.0
Re: [Qemu-block] [PATCH v2 0/2] Allow x-blockdev-del on a BB with a monitor-owned BDS, Alberto Garcia, 2016/02/24