[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v5 00/10] Make qemu-img/qemu-nbd/qemu-io CLI mor
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [PATCH v5 00/10] Make qemu-img/qemu-nbd/qemu-io CLI more flexible |
Date: |
Thu, 4 Feb 2016 16:44:06 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 02.02.2016 um 13:57 hat Daniel P. Berrange geschrieben:
> This series of patches expands the syntax of the qemu-img,
> qemu-nbd and qemu-io commands to make them more flexible.
>
> v0: https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg04365.html
> v1: https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg04014.html
> v2: https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg04354.html
> v3: https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg03381.html
> v4: https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg04984.html
>
> First all three gain a --object parameter, which allows
> instantiation of user creatable object types. The immediate
> use case is to allow for creation of the 'secret' object
> type to pass passwords for curl, iscsi and rbd drivers.
> For qemu-nbd this will also be needed to create TLS
> certificates for encryption support.
>
> Then all three gain a '--image-opts' parameter which causes
> the positional filenames to be interepreted as option strings
> rather tha nplain filenames. This avoids the need to use the
> JSON syntax, or to add custom CLI args for each block backend
> option that exists. The immediate use case is to allow the
> user to specify the ID of the 'secret' object they just created.
>
> Finally, there are a few small cleanup patches
>
> The first 4 patches in this series are a pre-requisite for
> 3 other series
>
> - Support for TLS in NBD
> - Support for secrets for passwd auth in curl, rbd, iscsi
> (fixes a CVE issue in libvirt)
> - Support for LUKS encryption passwords
Apart from the few comments that were made (including my own that I just
sent), this looks good to me.
Kevin
- [Qemu-block] [PATCH v5 10/10] qemu-io: use no_argument/required_argument constants, (continued)
Re: [Qemu-block] [PATCH v5 07/10] qemu-img: allow specifying image as a set of options args, Eric Blake, 2016/02/04
Re: [Qemu-block] [PATCH v5 00/10] Make qemu-img/qemu-nbd/qemu-io CLI more flexible,
Kevin Wolf <=