[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v5 0/2] block: Reject negative values for thrott
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-block] [PATCH v5 0/2] block: Reject negative values for throttling options |
|
Date: |
Wed, 20 Jan 2016 13:38:28 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 20.01.2016 um 05:21 hat Fam Zheng geschrieben:
> v5: Add valid value testing in iotests. [Berto]
> Add details in commit message. [Markus]
> Use "%lld" in format string. [Markus]
> Fix ")" -> "]" in error message. [Kevin]
>
> Now the negative values are silently converted to a huge positive number
> because we are doing implicit casting from uint64_t to double. Fix it and add
> a
> test case (this was once fixed in 7d81c1413c9 but regressed when the block
> device option parsing code was changed).
Thanks, applied to the block branch.
Kevin