Re: [Qemu-block] [Qemu-devel] [PATCH v5 0/2] block: Reject negative values for throttling options

[Fam Zheng]

On Wed, 01/20 08:25, Markus Armbruster wrote:
> Fam Zheng <address@hidden> writes:
> 
> > v5: Add valid value testing in iotests. [Berto]
> >     Add details in commit message. [Markus]
> >     Use "%lld" in format string. [Markus]
> >     Fix ")" -> "]" in error message. [Kevin]
> >
> > Now the negative values are silently converted to a huge positive number
> > because we are doing implicit casting from uint64_t to double. Fix it and 
> > add a
> > test case (this was once fixed in 7d81c1413c9 but regressed when the block
> > device option parsing code was changed).
> 
> Series
> Reviewed-by: Markus Armbruster <address@hidden>

Thanks!

Fam