[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v2 3/9] block: Assert no write requests under BDRV_O
From: |
Kevin Wolf |
Subject: |
[Qemu-block] [PATCH v2 3/9] block: Assert no write requests under BDRV_O_INCOMING |
Date: |
Wed, 13 Jan 2016 17:37:10 +0100 |
As long as BDRV_O_INCOMING is set, the image file is only opened so we
have a file descriptor for it. We're definitely not supposed to modify
the image, it's still owned by the migration source.
Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
block/io.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/block/io.c b/block/io.c
index 63e3678..2f19f61 100644
--- a/block/io.c
+++ b/block/io.c
@@ -1300,6 +1300,7 @@ static int coroutine_fn
bdrv_co_do_pwritev(BlockDriverState *bs,
if (bs->read_only) {
return -EPERM;
}
+ assert(!(bs->open_flags & BDRV_O_INCOMING));
ret = bdrv_check_byte_request(bs, offset, bytes);
if (ret < 0) {
@@ -2461,6 +2462,7 @@ int coroutine_fn bdrv_co_discard(BlockDriverState *bs,
int64_t sector_num,
} else if (bs->read_only) {
return -EPERM;
}
+ assert(!(bs->open_flags & BDRV_O_INCOMING));
/* Do nothing if disabled. */
if (!(bs->open_flags & BDRV_O_UNMAP)) {
--
1.8.3.1
- [Qemu-block] [PATCH v2 0/9] block/qcow2: Migration handoff fixes and cleanups, Kevin Wolf, 2016/01/13
- [Qemu-block] [PATCH v2 2/9] qcow2: Write full header on image creation, Kevin Wolf, 2016/01/13
- [Qemu-block] [PATCH v2 1/9] qcow2: Write feature table only for v3 images, Kevin Wolf, 2016/01/13
- [Qemu-block] [PATCH v2 3/9] block: Assert no write requests under BDRV_O_INCOMING,
Kevin Wolf <=
- [Qemu-block] [PATCH v2 4/9] block: Fix error path in bdrv_invalidate_cache(), Kevin Wolf, 2016/01/13
- [Qemu-block] [PATCH v2 6/9] block: Inactivate BDS when migration completes, Kevin Wolf, 2016/01/13
- [Qemu-block] [PATCH v2 5/9] block: Rename BDRV_O_INCOMING to BDRV_O_INACTIVE, Kevin Wolf, 2016/01/13
- [Qemu-block] [PATCH v2 7/9] qcow2: Implement .bdrv_inactivate, Kevin Wolf, 2016/01/13
- [Qemu-block] [PATCH v2 8/9] qcow2: Fix BDRV_O_INACTIVE handling in qcow2_invalidate_cache(), Kevin Wolf, 2016/01/13
- [Qemu-block] [PATCH v2 9/9] qcow2: Make image inaccessible after failed qcow2_invalidate_cache(), Kevin Wolf, 2016/01/13
- Re: [Qemu-block] [PATCH v2 0/9] block/qcow2: Migration handoff fixes and cleanups, Kevin Wolf, 2016/01/19