[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 13/15] qemu-img: Make MapEntry a QAPI struct
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-block] [PATCH v3 13/15] qemu-img: Make MapEntry a QAPI struct |
|
Date: |
Wed, 25 Nov 2015 22:19:19 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 11/25/2015 10:05 PM, Fam Zheng wrote:
> The "flags" bit mask is expanded to two booleans, "data" and "zero";
> "bs" is replaced with "filename" string.
>
> Refactor the merge conditions in img_map() into entry_mergable().
s/mergable/mergeable/ here and in the patch body
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> qapi/block-core.json | 27 ++++++++++++++++++++
> qemu-img.c | 71
> +++++++++++++++++++++++++++++++---------------------
> 2 files changed, 69 insertions(+), 29 deletions(-)
>
With the spelling fix,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v3 05/15] iscsi: Assign bs to file in iscsi_co_get_block_status, (continued)
- [Qemu-block] [PATCH v3 05/15] iscsi: Assign bs to file in iscsi_co_get_block_status, Fam Zheng, 2015/11/26
- [Qemu-block] [PATCH v3 06/15] parallels: Assign bs->file->bs to file in parallels_co_get_block_status, Fam Zheng, 2015/11/26
- [Qemu-block] [PATCH v3 07/15] qed: Assign bs->file->bs to file in bdrv_qed_co_get_block_status, Fam Zheng, 2015/11/26
- [Qemu-block] [PATCH v3 08/15] sheepdog: Assign bs to file in sd_co_get_block_status, Fam Zheng, 2015/11/26
- [Qemu-block] [PATCH v3 09/15] vdi: Assign bs->file->bs to file in vdi_co_get_block_status, Fam Zheng, 2015/11/26
- [Qemu-block] [PATCH v3 10/15] vpc: Assign bs->file->bs to file in vpc_co_get_block_status, Fam Zheng, 2015/11/26
- [Qemu-block] [PATCH v3 11/15] vmdk: Return extent's file in bdrv_get_block_status, Fam Zheng, 2015/11/26
- [Qemu-block] [PATCH v3 12/15] qemu-img: In "map", use the returned "file" from bdrv_get_block_status, Fam Zheng, 2015/11/26
- [Qemu-block] [PATCH v3 13/15] qemu-img: Make MapEntry a QAPI struct, Fam Zheng, 2015/11/26
- Re: [Qemu-block] [PATCH v3 13/15] qemu-img: Make MapEntry a QAPI struct,
Eric Blake <=
- [Qemu-block] [PATCH v3 14/15] qemu-img: Use QAPI visitor to generate JSON, Fam Zheng, 2015/11/26
- [Qemu-block] [PATCH v3 15/15] iotests: Add "qemu-img map" test for VMDK extents, Fam Zheng, 2015/11/26
- Re: [Qemu-block] [PATCH v3 00/15] qemu-img map: Allow driver to return file of the allocated block, Stefan Hajnoczi, 2015/11/30