[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v11 19/28] qapi: Change munging of
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v11 19/28] qapi: Change munging of CamelCase enum values |
Date: |
Thu, 12 Nov 2015 09:34:16 +0100 |
Hi,
> > If desired, I can prepare an alternate patch that adds the dash to the
> > qapi enum definition, to see what we think.
>
> If Gerd is fine with the rename, let's do it.
No need to do so I think ...
> >> - [INPUT_BUTTON_WHEEL_UP] = SDL_BUTTON(SDL_BUTTON_WHEELUP),
> >> - [INPUT_BUTTON_WHEEL_DOWN] = SDL_BUTTON(SDL_BUTTON_WHEELDOWN),
> >> + [INPUT_BUTTON_WHEELUP] = SDL_BUTTON(SDL_BUTTON_WHEELUP),
> >> + [INPUT_BUTTON_WHEELDOWN] = SDL_BUTTON(SDL_BUTTON_WHEELDOWN),
> >
> > Since SDL already spells the names without space, it's not the end of
> > the world if we do likewise.
>
> Good point.
This doesn't look too bad. And even if x-input-send-event isn't
official api I'd prefer to not break it for such a minor cosmetic issue.
cheers,
Gerd
Re: [Qemu-block] [Qemu-devel] [PATCH v11 19/28] qapi: Change munging of CamelCase enum values, Eric Blake, 2015/11/13