[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 1/2] iscsi: Translate scsi sense into error code
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-block] [PATCH 1/2] iscsi: Translate scsi sense into error code |
Date: |
Thu, 22 Oct 2015 10:45:45 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 22/10/2015 10:31, Peter Lieven wrote:
>
> + switch (sense->key) {
> + case SCSI_SENSE_NO_SENSE:
> + return 0;
> + break;
> + case SCSI_SENSE_NOT_READY:
> + return -EBUSY;
> + break;
> + case SCSI_SENSE_DATA_PROTECTION:
> + return -EACCES;
Probably EPERM, not EACCES.
> + break;
> + case SCSI_SENSE_COMMAND_ABORTED:
> + return -ECANCELED;
> + break;
> + case SCSI_SENSE_ILLEGAL_REQUEST:
> + /* Parse ASCQ */
> + break;
> + default:
> + return -EIO;
> + break;
> + }
> + switch (sense->ascq) {
> + case SCSI_SENSE_ASCQ_PARAMETER_LIST_LENGTH_ERROR:
> + case SCSI_SENSE_ASCQ_INVALID_OPERATION_CODE:
> + case SCSI_SENSE_ASCQ_INVALID_FIELD_IN_CDB:
> + case SCSI_SENSE_ASCQ_INVALID_FIELD_IN_PARAMETER_LIST:
> + ret = -EINVAL;
> + break;
> + case SCSI_SENSE_ASCQ_LBA_OUT_OF_RANGE:
> + ret = -ERANGE;
> + break;
> + case SCSI_SENSE_ASCQ_LOGICAL_UNIT_NOT_SUPPORTED:
> + ret = -ENOTSUP;
> + break;
> + case SCSI_SENSE_ASCQ_WRITE_PROTECTED:
> + ret = -EACCES;
Same here.
Paolo
> + break;
> + case SCSI_SENSE_ASCQ_MEDIUM_NOT_PRESENT:
> + case SCSI_SENSE_ASCQ_MEDIUM_NOT_PRESENT_TRAY_CLOSED:
> + case SCSI_SENSE_ASCQ_MEDIUM_NOT_PRESENT_TRAY_OPEN:
> + ret = -ENOMEDIUM;
> + break;
> + default:
> + ret = -EIO;
> + break;
> + }
[Qemu-block] [PATCH 2/2] qcow2: Translate -ERANGE to -ENOSPC, Fam Zheng, 2015/10/22
Re: [Qemu-block] [PATCH 0/2] Fix werror=enospc for qcow2 on iscsi, Peter Lieven, 2015/10/22
Re: [Qemu-block] [PATCH 0/2] Fix werror=enospc for qcow2 on iscsi, Paolo Bonzini, 2015/10/22