[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v5 2/6] block: Avoid BlockDriverState.filename
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v5 2/6] block: Avoid BlockDriverState.filename |
Date: |
Mon, 19 Oct 2015 14:35:19 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 10/19/2015 12:49 PM, Max Reitz wrote:
> In places which directly pass a filename to the OS, we should not use
> the filename field at all but exact_filename instead (although the
> former currently equals the latter if that is set).
>
> In raw_open_common(), we do not need to access BDS.filename because we
> already have a local variable pointing to the filename.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block.c | 5 +++--
> block/gluster.c | 2 +-
> block/raw-posix.c | 8 ++++----
> block/raw-win32.c | 4 ++--
> 4 files changed, 10 insertions(+), 9 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature