[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 05/12] aio: introduce aio_{disable, enable}_clie
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [PATCH 05/12] aio: introduce aio_{disable, enable}_clients |
Date: |
Fri, 9 Oct 2015 16:10:53 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 09.10.2015 um 07:45 hat Fam Zheng geschrieben:
> Signed-off-by: Fam Zheng <address@hidden>
> +void aio_disable_enable_clients(AioContext *ctx, int clients_mask,
> + bool is_disable)
> +{
> + int i = 1;
> + int n = 0;
> + aio_context_acquire(ctx);
> +
> + while (clients_mask) {
> + bool b = clients_mask & 0x1;
> + clients_mask >>= 1;
> + n++;
> + i <<= 1;
> + if (!b) {
> + continue;
> + }
> + if (ctx->client_disable_counters[n]) {
> + return true;
async.c: In function 'aio_disable_enable_clients':
async.c:401:13: error: 'return' with a value, in function returning void
[-Werror]
return true;
> + }
> + }
> + aio_context_release(ctx);
> +}
Kevin
- [Qemu-block] [PATCH 11/12] block: Introduce BlockDriver.bdrv_drain callback, (continued)
- [Qemu-block] [PATCH 11/12] block: Introduce BlockDriver.bdrv_drain callback, Fam Zheng, 2015/10/09
- [Qemu-block] [PATCH 08/12] block: Add "drained begin/end" for transactional backup, Fam Zheng, 2015/10/09
- [Qemu-block] [PATCH 12/12] qed: Implement .bdrv_drain, Fam Zheng, 2015/10/09
- [Qemu-block] [PATCH 02/12] aio: Save fd client type to AioHandler, Fam Zheng, 2015/10/09
- [Qemu-block] [PATCH 06/12] block: Introduce "drained begin/end" API, Fam Zheng, 2015/10/09
- [Qemu-block] [PATCH 07/12] block: Add "drained begin/end" for transactional external snapshot, Fam Zheng, 2015/10/09
- [Qemu-block] [PATCH 04/12] dataplane: Mark host notifiers' client type as "external", Fam Zheng, 2015/10/10
- [Qemu-block] [PATCH 05/12] aio: introduce aio_{disable, enable}_clients, Fam Zheng, 2015/10/10
[Qemu-block] [PATCH 09/12] block: Add "drained begin/end" for transactional blockdev-backup, Fam Zheng, 2015/10/10
[Qemu-block] [PATCH 10/12] block: Add "drained begin/end" for internal snapshot, Fam Zheng, 2015/10/10