[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child |
Date: |
Mon, 14 Sep 2015 18:09:51 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Kevin Wolf <address@hidden> writes:
> Am 14.09.2015 um 16:36 hat Markus Armbruster geschrieben:
>> Wen Congyang <address@hidden> writes:
>> > diff --git a/qmp-commands.hx b/qmp-commands.hx
>> > index 495670b..139a23b 100644
>> > --- a/qmp-commands.hx
>> > +++ b/qmp-commands.hx
>> > @@ -4053,6 +4053,59 @@ Example:
>> > EQMP
>> >
>> > {
>> > + .name = "x-child-add",
>> > + .args_type = "parent:B,child:B",
>> > + .mhandler.cmd_new = qmp_marshal_input_x_child_add,
>> > + },
>> > +
>> > +SQMP
>> > +x-child-add
>> > +------------
>> > +
>> > +Add a child to a quorum node.
>> > +
>> > +Arguments:
>> > +
>> > +- "parent": the quorum's id or node name
>> > +- "child": the child node-name which will be added
>>
>> Node name parameters are usually named node-name or, if there's more
>> than one, FOO-node-name. Unless we want to abandon that convention,
>> this should therefore be node-name and child-node-name, or parent-node
>> name and child-node-name.
>
> Didn't we come to the conclusion that foo-node-name is redundant and
> should just be foo, leaving things like node-name only for cases where
> there is no foo?
I don't remember :)
I'm fine with simpler names.
- Re: [Qemu-block] [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add, (continued)
[Qemu-block] [PATCH v3 5/5] hmp: add monitor command to add/remove a child, Wen Congyang, 2015/09/10
[Qemu-block] [PATCH v3 2/5] Add new block driver interface to add/delete a BDS's child, Wen Congyang, 2015/09/10
[Qemu-block] [PATCH v3 4/5] qmp: add monitor command to add/remove a child, Wen Congyang, 2015/09/10
- Re: [Qemu-block] [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child, Daniel P. Berrange, 2015/09/10
- Re: [Qemu-block] [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child, Markus Armbruster, 2015/09/14
- Re: [Qemu-block] [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child, Wen Congyang, 2015/09/14
- Re: [Qemu-block] [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child, Markus Armbruster, 2015/09/15
- Re: [Qemu-block] [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child, Wen Congyang, 2015/09/15
- Re: [Qemu-block] [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child, Wen Congyang, 2015/09/16
- Re: [Qemu-block] [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child, Markus Armbruster, 2015/09/16
Re: [Qemu-block] [PATCH v3 4/5] qmp: add monitor command to add/remove a child, Kevin Wolf, 2015/09/14