[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 11/13] qcow2: Support updating driver-specifi
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH v3 11/13] qcow2: Support updating driver-specific options in reopen |
Date: |
Mon, 7 Sep 2015 21:44:56 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 07.09.2015 15:26, Kevin Wolf wrote:
> For updating the cache sizes or disabling lazy refcounts
And updating the cache clean timer, too.
> there is a bit
> more to do than just changing the variables, but otherwise we're all set
> for changing options during bdrv_reopen().
>
> Just implement the missing pieces and hook the functions up in
> bdrv_reopen().
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/qcow2.c | 81
> ++++++++++++++++++++++++++++++++++++++++++++++++++++-------
> 1 file changed, 72 insertions(+), 9 deletions(-)
Whether you mention it or not (can be fixed up when applying the patch,
too):
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v3 05/13] qcow2: Factor out qcow2_update_options(), (continued)
- [Qemu-block] [PATCH v3 05/13] qcow2: Factor out qcow2_update_options(), Kevin Wolf, 2015/09/07
- [Qemu-block] [PATCH v3 06/13] qcow2: Move qcow2_update_options() call up, Kevin Wolf, 2015/09/07
- [Qemu-block] [PATCH v3 07/13] qcow2: Move rest of option handling to qcow2_update_options(), Kevin Wolf, 2015/09/07
- [Qemu-block] [PATCH v3 09/13] qcow2: Fix memory leak in qcow2_update_options() error path, Kevin Wolf, 2015/09/07
- [Qemu-block] [PATCH v3 08/13] qcow2: Leave s unchanged on qcow2_update_options() failure, Kevin Wolf, 2015/09/07
- [Qemu-block] [PATCH v3 10/13] qcow2: Make qcow2_update_options() suitable for transactions, Kevin Wolf, 2015/09/07
- [Qemu-block] [PATCH v3 11/13] qcow2: Support updating driver-specific options in reopen, Kevin Wolf, 2015/09/07
- Re: [Qemu-block] [PATCH v3 11/13] qcow2: Support updating driver-specific options in reopen,
Max Reitz <=
- [Qemu-block] [PATCH v3 12/13] qemu-iotests: Reopen qcow2 with lazy-refcounts change, Kevin Wolf, 2015/09/07
- [Qemu-block] [PATCH v3 13/13] qemu-iotests: More qcow2 reopen tests, Kevin Wolf, 2015/09/07