qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-block] [PATCH 0/5] block: Drop drv parameter from bdrv_open()


From: Max Reitz
Subject: [Qemu-block] [PATCH 0/5] block: Drop drv parameter from bdrv_open()
Date: Wed, 26 Aug 2015 19:47:47 +0200

We don't really need that parameter, so let's drop it. Doing so may even
fix some bugs, see
http://lists.nongnu.org/archive/html/qemu-block/2015-08/msg00171.html.

In the course of writing this series, I had to decide whether the make
sure all callers of bdrv_find_whitelisted_format() would still only
accept whitelisted formats, which you'd think would be a good idea; but
the only caller left was qmp_change_blockdev(), so I guess noone really
cared about it anymore, instead relying on use_bdrv_whitelist alone.

So I decided dropped bdrv_find_whitelisted_format() completely. If you
feel this is a bad decision, feel free to argue but then I guess we'll
have to reevaluate all bdrv_find_format() calls whether they should
actually be bdrv_find_whitelisted_format() calls.


Max Reitz (5):
  block: Always pass NULL as drv for bdrv_open()
  block: Drop drv parameter from bdrv_open()
  block: Drop drv parameter from bdrv_open_inherit()
  block: Drop drv parameter from bdrv_fill_options()
  block: Drop bdrv_find_whitelisted_format()

 block.c               | 108 +++++++++++++++++++-------------------------------
 block/block-backend.c |   2 +-
 block/parallels.c     |   2 +-
 block/qcow.c          |   2 +-
 block/qcow2.c         |  18 ++++++---
 block/qed.c           |   2 +-
 block/sheepdog.c      |   5 +--
 block/vdi.c           |   2 +-
 block/vhdx.c          |   2 +-
 block/vmdk.c          |   7 ++--
 block/vpc.c           |   2 +-
 block/vvfat.c         |   8 +++-
 blockdev.c            |  72 +++++++++++++--------------------
 include/block/block.h |   5 +--
 14 files changed, 100 insertions(+), 137 deletions(-)

-- 
2.4.6




reply via email to

[Prev in Thread] Current Thread [Next in Thread]