[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v3 5/5] iotests: Test changed Quorum filename
From: |
Max Reitz |
Subject: |
[Qemu-block] [PATCH v3 5/5] iotests: Test changed Quorum filename |
Date: |
Wed, 12 Aug 2015 17:48:22 +0200 |
After drive-mirror replacing a Quorum child, the filename of the Quorum
BDS should reflect the change. This patch replaces the existing test for
whether the operation did actually exchange the BDS (which simply tested
whether the new BDS existed) by a test which examines the children list
contained in the Quorum BDS's filename as returned by query-block.
As a nice side effect of confirming that the new BDS actually belongs to
the Quorum BDS, this checks whether the filename was properly updated.
Signed-off-by: Max Reitz <address@hidden>
---
tests/qemu-iotests/041 | 17 +++++++++++++----
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041
index 3d46ed7..316f42a 100755
--- a/tests/qemu-iotests/041
+++ b/tests/qemu-iotests/041
@@ -18,6 +18,7 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#
+import json
import time
import os
import iotests
@@ -908,10 +909,18 @@ class TestRepairQuorum(iotests.QMPTestCase):
self.assert_qmp(result, 'return', {})
self.complete_and_wait(drive="quorum0")
- result = self.vm.qmp('query-named-block-nodes')
- self.assert_qmp(result, 'return[0]/file', quorum_repair_img)
- # TODO: a better test requiring some QEMU infrastructure will be added
- # to check that this file is really driven by quorum
+
+ result = self.vm.qmp('query-block')
+ for blockdev in result['return']:
+ if blockdev['device'] == 'quorum0':
+ filename = blockdev['inserted']['image']['filename']
+ self.assertEquals(filename[:5], 'json:')
+ children = json.loads(filename[5:])['children']
+ self.assertEquals(children[0]['file']['filename'], quorum_img1)
+ self.assertEquals(children[1]['file']['filename'],
+ quorum_repair_img)
+ self.assertEquals(children[2]['file']['filename'], quorum_img3)
+
self.vm.shutdown()
if __name__ == '__main__':
--
2.4.6
- [Qemu-block] [PATCH v3 0/5] block: Drop BDS.filename, Max Reitz, 2015/08/12
- [Qemu-block] [PATCH v3 1/5] block: Change bdrv_get_encrypted_filename(), Max Reitz, 2015/08/12
- [Qemu-block] [PATCH v3 2/5] block: Avoid BlockDriverState.filename, Max Reitz, 2015/08/12
- [Qemu-block] [PATCH v3 3/5] block: Add bdrv_filename(), Max Reitz, 2015/08/12
- [Qemu-block] [PATCH v3 5/5] iotests: Test changed Quorum filename,
Max Reitz <=
- [Qemu-block] [PATCH v3 4/5] block: Drop BlockDriverState.filename, Max Reitz, 2015/08/12
- Re: [Qemu-block] [PATCH v3 0/5] block: Drop BDS.filename, Kevin Wolf, 2015/08/13