[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3] raw-posix.c: Make physical devices usable in
From: |
Programmingkid |
Subject: |
Re: [Qemu-block] [PATCH v3] raw-posix.c: Make physical devices usable in QEMU under Mac OS X host |
Date: |
Fri, 24 Jul 2015 11:37:50 -0400 |
On Jul 24, 2015, at 11:00 AM, Stefan Hajnoczi wrote:
> On Fri, Jul 17, 2015 at 08:19:16PM -0400, Programmingkid wrote:
>> @@ -2014,7 +2015,9 @@ kern_return_t GetBSDPath( io_iterator_t mediaIterator,
>> char *bsdPath, CFIndex ma
>> if ( bsdPathAsCFString ) {
>> size_t devPathLength;
>> strcpy( bsdPath, _PATH_DEV );
>> - strcat( bsdPath, "r" );
>> + if (flags & BDRV_O_NOCACHE) {
>> + strcat(bsdPath, "r");
>> + }
>> devPathLength = strlen( bsdPath );
>> if ( CFStringGetCString( bsdPathAsCFString, bsdPath +
>> devPathLength, maxPathSize - devPathLength, kCFStringEncodingASCII ) ) {
>> kernResult = KERN_SUCCESS;
>
> This hunk should be a separate patch.
If I made the changes to the GetBSDPath() function its own patch, QEMU would no
longer compile. The addition of a flags argument would cause this issue.