[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 0/4] rbd cleanup and settings prece
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 0/4] rbd cleanup and settings precedence fixes |
Date: |
Tue, 14 Jul 2015 16:20:27 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 09.07.2015 um 11:59 hat Stefan Hajnoczi geschrieben:
> On Tue, Jun 30, 2015 at 11:28:18AM -0700, Josh Durgin wrote:
> > Ping
> >
> > On 06/10/2015 08:28 PM, Josh Durgin wrote:
> > >Patches 1 and 2 are simple cleanups. 3 and 4 fix the precedence of
> > >cache options and ceph settings. The cache option precedence in
> > >particular is important due to the potential for misconfigurations
> > >(ceph.conf setting rbd_cache=true, qemu setting cache=none) to
> > >accidentally put data at risk.
> > >
> > >Josh Durgin (4):
> > > rbd: remove unused constants and fields
> > > MAINTAINERS: update email address
> > > rbd: make qemu's cache setting override any ceph setting
> > > rbd: fix ceph settings precedence
> > >
> > > MAINTAINERS | 2 +-
> > > block/rbd.c | 64
> > > +++++++++++++++++++++++++++++++++----------------------------
> > > 2 files changed, 36 insertions(+), 30 deletions(-)
>
> This should go via Jeff:
>
> $ scripts/get_maintainer.pl -f block/rbd.c
> Josh Durgin <address@hidden> (supporter:RBD)
> Jeff Cody <address@hidden> (supporter:RBD)
> Kevin Wolf <address@hidden> (supporter:Block layer core)
> address@hidden (open list:RBD)
>
> Jeff is currently on vacation but will be back before the QEMU 2.4-rc1
> tag is made.
Considering that Josh is the primary maintainer for rbd and Jeff is just
merging patches for him, and that Jeff has already given R-b for patches
1 to 3, and that Jeff doesn't seem to be back yet, and that the patches
look good to me, I'm taking this through my tree for -rc1.
(I guess this is my longest "thanks, applied" sentence so far...)
Kevin
pgpeJKxUBaogk.pgp
Description: PGP signature