[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 07/13] block: Use QemuOpts in bdrv_open_commo
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v2 07/13] block: Use QemuOpts in bdrv_open_common() |
Date: |
Wed, 10 Jun 2015 15:42:17 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 06/10/2015 07:47 AM, Kevin Wolf wrote:
> Instead of manually parsing options and then deleting them from the
> options QDict, just use QemuOpts like most other places that deal with
> block device options.
>
> More options will be added there and then QemuOpts is a lot more
> managable than open-coding everything.
s/managable/manageable/
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block.c | 39 ++++++++++++++++++++++++++++++++++-----
> 1 file changed, 34 insertions(+), 5 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [PATCH v2 01/13] qdict: Add qdict_array_entries(), (continued)
- [Qemu-block] [PATCH v2 03/13] check-qdict: Test cases for new functions, Kevin Wolf, 2015/06/10
- [Qemu-block] [PATCH v2 04/13] quorum: Use bdrv_open_image(), Kevin Wolf, 2015/06/10
- [Qemu-block] [PATCH v2 06/13] block: Use macro for cache option names, Kevin Wolf, 2015/06/10
- [Qemu-block] [PATCH v2 02/13] qdict: Add qdict_{set, copy}_default(), Kevin Wolf, 2015/06/10
- [Qemu-block] [PATCH v2 05/13] vmdk: Use bdrv_open_image(), Kevin Wolf, 2015/06/10
- [Qemu-block] [PATCH v2 07/13] block: Use QemuOpts in bdrv_open_common(), Kevin Wolf, 2015/06/10
- [Qemu-block] [PATCH v2 09/13] block: Drain requests before swapping nodes in bdrv_swap(), Kevin Wolf, 2015/06/10
- [Qemu-block] [PATCH v2 10/13] queue.h: Add QLIST_FIX_HEAD_PTR(), Kevin Wolf, 2015/06/10
- [Qemu-block] [PATCH v2 12/13] block: Add BlockDriverState.inherits_from, Kevin Wolf, 2015/06/10
- [Qemu-block] [PATCH v2 08/13] block: Move flag inheritance to bdrv_open_inherit(), Kevin Wolf, 2015/06/10
- [Qemu-block] [PATCH v2 11/13] block: Add list of children to BlockDriverState, Kevin Wolf, 2015/06/10