[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 1/9] qapi: Rename 'dirty-bitmap' mode to 'increm
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-block] [PATCH 1/9] qapi: Rename 'dirty-bitmap' mode to 'incremental' |
|
Date: |
Thu, 04 Jun 2015 20:34:27 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 06/04/2015 06:20 PM, John Snow wrote:
> If we wish to make differential backups a feature that's easy to access,
> it might be pertinent to rename the "dirty-bitmap" mode to "incremental"
> to make it clear what /type/ of backup the dirty-bitmap is helping us
> perform.
>
> This is an API breaking change, but 2.4 has not yet gone live,
> so we have this flexibility.
Agreed - I like the new name, and you are right that NOW is the time to
do it.
>
> Signed-off-by: John Snow <address@hidden>
> ---
> block/backup.c | 10 +++++-----
> block/mirror.c | 4 ++--
> docs/bitmaps.md | 8 ++++----
> include/block/block_int.h | 2 +-
> qapi/block-core.json | 8 ++++----
> qmp-commands.hx | 6 +++---
> tests/qemu-iotests/124 | 10 +++++-----
> 7 files changed, 24 insertions(+), 24 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH 0/9] block: add differential backup support, John Snow, 2015/06/04
- [Qemu-block] [PATCH 2/9] hbitmap: add hbitmap_copy, John Snow, 2015/06/04
- [Qemu-block] [PATCH 3/9] block: add bdrv_copy_dirty_bitmap, John Snow, 2015/06/04
- [Qemu-block] [PATCH 1/9] qapi: Rename 'dirty-bitmap' mode to 'incremental', John Snow, 2015/06/04
- [Qemu-block] [PATCH 4/9] qapi: add Copy data type for bitmaps, John Snow, 2015/06/04
- [Qemu-block] [PATCH 7/9] block: add differential backup mode, John Snow, 2015/06/04
- [Qemu-block] [PATCH 5/9] qmp: add qmp cmd block-dirty-bitmap-copy, John Snow, 2015/06/04
- [Qemu-block] [PATCH 6/9] qmp: add block-dirty-bitmap-copy transaction, John Snow, 2015/06/04
- [Qemu-block] [PATCH 9/9] iotests: add differential backup test, John Snow, 2015/06/04
- [Qemu-block] [PATCH 8/9] iotests: 124: support differential backups, John Snow, 2015/06/04
- Re: [Qemu-block] [Qemu-devel] [PATCH 0/9] block: add differential backup support, John Snow, 2015/06/23