[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [RFC PATCH 03/12] blockdev: Lock BDS during internal snapsh
From: |
Fam Zheng |
Subject: |
[Qemu-block] [RFC PATCH 03/12] blockdev: Lock BDS during internal snapshot transaction |
Date: |
Fri, 29 May 2015 18:53:16 +0800 |
Signed-off-by: Fam Zheng <address@hidden>
---
blockdev.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/blockdev.c b/blockdev.c
index 5eaf77e..46f8d60 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1262,6 +1262,7 @@ typedef struct InternalSnapshotState {
BlockDriverState *bs;
AioContext *aio_context;
QEMUSnapshotInfo sn;
+ bool needs_unlock;
} InternalSnapshotState;
static void internal_snapshot_prepare(BlkTransactionState *common,
@@ -1356,6 +1357,8 @@ static void internal_snapshot_prepare(BlkTransactionState
*common,
}
/* 4. succeed, mark a snapshot is created */
+ bdrv_lock(bs);
+ state->needs_unlock = true;
state->bs = bs;
}
@@ -1387,6 +1390,9 @@ static void internal_snapshot_clean(BlkTransactionState
*common)
InternalSnapshotState *state = DO_UPCAST(InternalSnapshotState,
common, common);
+ if (state->needs_unlock) {
+ bdrv_unlock(state->bs);
+ }
if (state->aio_context) {
aio_context_release(state->aio_context);
}
--
2.4.2
- [Qemu-block] [RFC PATCH 00/12] block: Protect block jobs with lock / unlock API, Fam Zheng, 2015/05/29
- [Qemu-block] [RFC PATCH 01/12] block: Use bdrv_drain to replace uncessary bdrv_drain_all, Fam Zheng, 2015/05/29
- [Qemu-block] [RFC PATCH 02/12] block: Introduce bdrv_lock and bdrv_unlock API, Fam Zheng, 2015/05/29
- [Qemu-block] [RFC PATCH 03/12] blockdev: Lock BDS during internal snapshot transaction,
Fam Zheng <=
- [Qemu-block] [RFC PATCH 04/12] blockdev: Lock BDS during external snapshot transaction, Fam Zheng, 2015/05/29
- [Qemu-block] [RFC PATCH 05/12] blockdev: Lock BDS during drive-backup transaction, Fam Zheng, 2015/05/29
- [Qemu-block] [RFC PATCH 06/12] blockdev: Lock BDS during blockdev-backup transaction, Fam Zheng, 2015/05/29
- [Qemu-block] [RFC PATCH 07/12] block-backend: Add blk_add_lock_unlock_notifier, Fam Zheng, 2015/05/29
- [Qemu-block] [RFC PATCH 08/12] virtio-blk: Move complete_request to 'ops' structure, Fam Zheng, 2015/05/29
- [Qemu-block] [RFC PATCH 09/12] virtio-blk: Don't handle output when backend is locked, Fam Zheng, 2015/05/29
- [Qemu-block] [RFC PATCH 10/12] virtio-scsi-dataplane: Add backend lock listener, Fam Zheng, 2015/05/29
- [Qemu-block] [RFC PATCH 11/12] nbd-server: Clear "can_read" when backend is locked, Fam Zheng, 2015/05/29
- [Qemu-block] [RFC PATCH 12/12] mirror: Protect source between bdrv_drain and bdrv_swap, Fam Zheng, 2015/05/29