[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v3 3/5] raw-posix: DPRINTF instead of DEBUG_BLOCK_PR
From: |
Dimitris Aragiorgis |
Subject: |
[Qemu-block] [PATCH v3 3/5] raw-posix: DPRINTF instead of DEBUG_BLOCK_PRINT |
Date: |
Thu, 14 May 2015 14:01:13 +0300 |
Building the QEMU tools fails if we #define DEBUG_BLOCK inside
block/raw-posix.c. Here instead of adding qemu-log.o in block-obj-y
so that DEBUG_BLOCK_PRINT can be used, we substitute the latter with
a simple DPRINTF() (that does not cause bit-rot).
Signed-off-by: Dimitris Aragiorgis <address@hidden>
---
block/raw-posix.c | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/block/raw-posix.c b/block/raw-posix.c
index fb58440..ff7dc4d 100644
--- a/block/raw-posix.c
+++ b/block/raw-posix.c
@@ -97,12 +97,17 @@
//#define DEBUG_FLOPPY
//#define DEBUG_BLOCK
-#if defined(DEBUG_BLOCK)
-#define DEBUG_BLOCK_PRINT(formatCstr, ...) do { if (qemu_log_enabled()) \
- { qemu_log(formatCstr, ## __VA_ARGS__); qemu_log_flush(); } } while (0)
+
+#ifdef DEBUG_BLOCK
+# define DEBUG_BLOCK_PRINT 1
#else
-#define DEBUG_BLOCK_PRINT(formatCstr, ...)
+# define DEBUG_BLOCK_PRINT 0
#endif
+#define DPRINTF(fmt, ...) \
+do { \
+ if (DEBUG_BLOCK_PRINT) \
+ printf(fmt, ## __VA_ARGS__); \
+} while (0)
/* OS X does not have O_DSYNC */
#ifndef O_DSYNC
@@ -1023,7 +1028,7 @@ static int xfs_write_zeroes(BDRVRawState *s, int64_t
offset, uint64_t bytes)
fl.l_len = bytes;
if (xfsctl(NULL, s->fd, XFS_IOC_ZERO_RANGE, &fl) < 0) {
- DEBUG_BLOCK_PRINT("cannot write zero range (%s)\n", strerror(errno));
+ DPRINTF("cannot write zero range (%s)\n", strerror(errno));
return -errno;
}
@@ -1040,7 +1045,7 @@ static int xfs_discard(BDRVRawState *s, int64_t offset,
uint64_t bytes)
fl.l_len = bytes;
if (xfsctl(NULL, s->fd, XFS_IOC_UNRESVSP64, &fl) < 0) {
- DEBUG_BLOCK_PRINT("cannot punch hole (%s)\n", strerror(errno));
+ DPRINTF("cannot punch hole (%s)\n", strerror(errno));
return -errno;
}
--
1.7.10.4