[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v3] block/vdi: Use bdrv_flush after
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v3] block/vdi: Use bdrv_flush after metadata updates |
Date: |
Thu, 7 May 2015 11:09:54 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, May 07, 2015 at 12:04:56PM +0800, Zhe Qiu wrote:
> From: phoeagon <address@hidden>
>
> In reference to
> b0ad5a455d7e5352d4c86ba945112011dbeadfb8~078a458e077d6b0db262c4b05fee51d01de2d1d2,
> metadata writes to qcow2/cow/qcow/vpc/vmdk are all synced prior to
> succeeding writes.
>
> Only when write is successful that bdrv_flush is called.
>
> Signed-off-by: Zhe Qiu <address@hidden>
> ---
> block/vdi.c | 3 +++
> 1 file changed, 3 insertions(+)
CCing Stefan Weil and Kevin Wolf (see output from
scripts/get_maintainer.pl -f block/vdi.c).
>
> diff --git a/block/vdi.c b/block/vdi.c
> index 7642ef3..dfe8ade 100644
> --- a/block/vdi.c
> +++ b/block/vdi.c
> @@ -713,6 +713,9 @@ static int vdi_co_write(BlockDriverState *bs,
> logout("will write %u block map sectors starting from entry %u\n",
> n_sectors, bmap_first);
> ret = bdrv_write(bs->file, offset, base, n_sectors);
> + if (ret >= 0) {
> + ret = bdrv_flush(bs->file);
> + }
> }
>
> return ret;
> --
> 2.4.0
>
>
pgprxl7PP3pat.pgp
Description: PGP signature
- [Qemu-block] [PATCH v3] block/vdi: Use bdrv_flush after metadata updates, Zhe Qiu, 2015/05/07
- Re: [Qemu-block] [Qemu-devel] [PATCH v3] block/vdi: Use bdrv_flush after metadata updates,
Stefan Hajnoczi <=
- Re: [Qemu-block] [PATCH v3] block/vdi: Use bdrv_flush after metadata updates, Eric Blake, 2015/05/07
- [Qemu-block] [PATCH v4] block/vdi: Use bdrv_flush after metadata updates, Zhe Qiu, 2015/05/07
- Re: [Qemu-block] [PATCH v4] block/vdi: Use bdrv_flush after metadata updates, Max Reitz, 2015/05/08
- Re: [Qemu-block] [PATCH v4] block/vdi: Use bdrv_flush after metadata updates, Kevin Wolf, 2015/05/08
- Re: [Qemu-block] [PATCH v4] block/vdi: Use bdrv_flush after metadata updates, phoeagon, 2015/05/08
- Re: [Qemu-block] [PATCH v4] block/vdi: Use bdrv_flush after metadata updates, Stefan Weil, 2015/05/08
- Re: [Qemu-block] [PATCH v4] block/vdi: Use bdrv_flush after metadata updates, phoeagon, 2015/05/08
- Re: [Qemu-block] [PATCH v4] block/vdi: Use bdrv_flush after metadata updates, phoeagon, 2015/05/08
- Re: [Qemu-block] [Qemu-devel] [PATCH v4] block/vdi: Use bdrv_flush after metadata updates, Stefan Weil, 2015/05/09
- Re: [Qemu-block] [Qemu-devel] [PATCH v4] block/vdi: Use bdrv_flush after metadata updates, phoeagon, 2015/05/09